Fix broken links detected by make linkcheck-files #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
| @@ -76,7 +76,7 @@ layer: | |||
|
|
|||
| Use this tool to manually erase a label on the `labels layer`. Other layers | |||
| will not be affected. The label eraser tool looks like this: | |||
|  | |||
|  | |||
There was a problem hiding this comment.
This doesn't appear correct, see:
https://github.com/napari/docs/blob/main/docs/images/labels-layer-eraser.png
It's causing a warning:
https://github.com/napari/docs/actions/runs/10563443854/job/29263666686?pr=484#step:9:1436
Let's revert?
Suggested change
|  | |
|  |
There was a problem hiding this comment.
Oh man, search and replace all strikes again 🙈 Will fix
| @@ -47,7 +47,7 @@ You can read a full history of the project’s founding and early development in | |||
|
|
|||
| Over time, napari has grown to over 80 direct contributors. Talley Lambert, from Harvard Medical School, began contributing around the time of Juan's blog post, and has been a critical driver of napari's development ever since. We have core developers located in three continents and three biweekly community calls spread across the day to try to accommodate users and contributors in any time zone. | |||
|
|
|||
| Read more about napari’s [mission and values](https://napari.org/community/mission_and_values.html), how to get started as a [contributor](https://napari.org/developers/contributing.html) or join us in our [zulip chat](https://napari.zulipchat.com/login/) for a more synchronous conversation. You can also follow us on [twitter](https://twitter.com/napari_imaging). | |||
| Read more about napari’s [mission and values](https://napari.org/community/mission_and_values.html), how to get started as a [contributor](https://napari.org/developers/contributing.html) or join us in our [zulip chat](https://napari.zulipchat.com/login/) for a more synchronous conversation. You can also follow us on [twitter](https://x.com/napari_imaging). | |||
There was a problem hiding this comment.
Suggested change
| Read more about napari’s [mission and values](https://napari.org/community/mission_and_values.html), how to get started as a [contributor](https://napari.org/developers/contributing.html) or join us in our [zulip chat](https://napari.zulipchat.com/login/) for a more synchronous conversation. You can also follow us on [twitter](https://x.com/napari_imaging). | |
| Read more about napari’s [mission and values](https://napari.org/stable/community/mission_and_values.html), how to get started as a [contributor](https://napari.org/stable/developers/contributing.html) or join us in our [zulip chat](https://napari.zulipchat.com/login/) for a more synchronous conversation. You can also follow us on [twitter](https://x.com/napari_imaging). |
I think those links work but rely on redirects/symlinks we want to get rid of long term right?
There was a problem hiding this comment.
Good catch, will include
| @@ -194,7 +194,7 @@ for NeuroImaging of Coma and Consciousness, which is dedicated to promoting | |||
| recovery of consciousness in people with severe brain injuries. This dataset is | |||
| a 100 micron resolution magnetic resonance imaging (MRI) scan of an ex vivo | |||
| human brain specimen. The brain specimen was donated by a [58-year-old woman](https://www.youtube.com/watch?v=Q-9jzBkoNuI) who had no history of neurological disease and died of non-neurological causes. | |||
| This dataset was originally described in [Edlow, B.L., Mareyam, A., Horn, A. _et al._ 7 Tesla MRI of the ex vivo human brain at 100 micron resolution. Sci Data 6, 244 (2019)](https://doi.org/10.1038/s41597-019-0254-8). | |||
| This dataset was originally described in [Edlow, B.L., Mareyam, A., Horn, A. _et al._ 7 Tesla MRI of the ex vivo human brain at 100 micron resolution. Sci Data 6, 244 (2019)](https://www.nature.com/articles/s41597-019-0254-8). | |||
There was a problem hiding this comment.
Is this change necessary? using the DOI is the best-practice.
psobolewskiPhD
requested changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
Related to
#474
Description
Fixes a number of broken links detected by
make linkcheck-files.A few comments:
further-resources/sample_data.md:17: [redirected permanently] [digitalpathologyassociation.org/whole-slide-imaging-repository](https://digitalpathologyassociation.org/whole-slide-imaging-repository) to [https://digitalpathologyassociation.org?preview_error](https://digitalpathologyassociation.org/?preview_error). I tried googling but only found this: http://www.wsirepository.org/ and it doesn't load. Any ideas?developers/architecture/app_model.md:288: [broken] https://github.com/napari/napari/blob/main/napari/_app_model/_submenus.py: 404 Client Error: Not Found for url: https://github.com/napari/napari/blob/main/napari/_app_model/_submenus.pyI couldn't find SubmenuItem in the codebase, maybe I'm missing somethingtutorials/tracking/cell_tracking.md:229: [broken] https://github.com/quantumjot/btrack/blob/main/models/cell_config.json: 404 Client Error: Not Found for url: https://github.com/quantumjot/btrack/blob/main/models/cell_config.json. Should we replace with a new link?A few items are left, mostly links to old code. I will try to replace with permalinks where I can, but not sure if I'll be able to find all of them. If that's the case I might try to ping the original authors for an appropriate substitution.