Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding sort_keys #17

Merged
merged 4 commits into from
Jul 26, 2023
Merged

Conversation

eudoroolivares2016
Copy link
Contributor

Minor spelling fixes

adds sort keys for granules will do collections some other time

testing:
start up python in the repo

from cmr import CollectionQuery, GranuleQuery, ToolQuery, ServiceQuery, VariableQuery
import json
api = GranuleQuery()
api.parameters(short_name="OMNO2", version="003", provider='GES_DISC', sort_key='-start_date')
granules = api.get(10)`

print(json.dumps(granules, indent=1))

ensure that the returned granules are sorted by the sort_key

@briannapagan
Copy link
Collaborator

We're in need of this feature at GES DISC - I had put in a request to be maintainer to help approve PRs months ago for python-cmr but it was never approved. Can I nudge @frankinspace to review/approve?

Copy link
Collaborator

@frankinspace frankinspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eudoroolivares2016 Can you please add an entry to the changelog (under the Unreleased header create a Added section and describe the new feature). Also, can you add a note in the readme about sort keys.

Thank you for the contribution!

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@frankinspace frankinspace merged commit d4ec4c5 into nasa:develop Jul 26, 2023
3 checks passed
@frankinspace frankinspace mentioned this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants