Fix cmr search after key error #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contributions @tyler-c2s . For the future, please create an entry in the 'Unreleased' section of the CHANGELOG summarizing what changes you have made (more info on what should go in the changelog can be found here: https://keepachangelog.com/en/1.1.0/) Again, thank you! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
During debugging adding readable_granule_name filter, I ran into key errors when making a request that returns zero hits. In these cases it looks like the CMR Search api does not send back
cmr-search-afterin the headers as expected in the code.Added a fix, and new recorded tests that would have caught this
Please let me know if you have any questions or concerns