Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KeyError for non-json query formats #43

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

chuckwondo
Copy link
Collaborator

Also, fix bug in result counting that caused up to limit^2 results to be feched rather than only limit results.

Fixes #42

Also, fix bug in result counting that caused up to _limit^2_ results to
be feched rather than only _limit_ results.

Fixes nasa#42
Copy link
Collaborator

@frankinspace frankinspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, can you just add a comment in the 'Fixed' section of the changelog?

@chuckwondo
Copy link
Collaborator Author

Looks great, can you just add a comment in the 'Fixed' section of the changelog?

Ah, of course. Sorry about that.

@frankinspace frankinspace merged commit 8738280 into nasa:develop Apr 23, 2024
7 checks passed
@chuckwondo chuckwondo deleted the non-json-keyerror branch July 6, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError: 'feed' when using format other than 'json'
2 participants