Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tagged unions, vectors and arrays in pushAny and toAny #66

Merged
merged 20 commits into from
Mar 19, 2024

Conversation

T1nk3r1
Copy link
Contributor

@T1nk3r1 T1nk3r1 commented Mar 10, 2024

No description provided.

@T1nk3r1 T1nk3r1 changed the title Add support for tagged unions in pushAny and toAny Add support for tagged unions, vectors and arrays in pushAny and toAny Mar 14, 2024
src/lib.zig Outdated Show resolved Hide resolved
@natecraddock
Copy link
Owner

Just one small thing to fix and all the tests will pass. Sorry for taking a while to get to this!

@VisenDev
Copy link
Contributor

Very nice!

A warning though, if my current pr gets merged there might be a few merge conflicts since I changed up the toAny api a little

@T1nk3r1
Copy link
Contributor Author

T1nk3r1 commented Mar 17, 2024

Very nice!

A warning though, if my current pr gets merged there might be a few merge conflicts since I changed up the toAny api a little

I just resolved the conflicts in this branch, so that your pr can be merged

@natecraddock
Copy link
Owner

@T1nk3r1 I just merged the PR from @VisenDev. It looks like you already resolved the conflicts. I'll merge this once you update this PR

@natecraddock natecraddock merged commit df0c1aa into natecraddock:main Mar 19, 2024
3 checks passed
@T1nk3r1 T1nk3r1 deleted the tagged-union branch March 20, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants