-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installing peer dependencies on windows #33
Comments
Thanks for the specific repro information - the quotation marks, however, don't seem to be working for me (I'm on NPM v5.6.0). Removing the '-0' seems to work, though, which is how I'm going to resolve this issue (in fact, just merged the fix branch into master). I'm going to do a new release soon, but if you need the fix now you can pull from the latest |
Edit: tests are taking a long time on Travis, but will merge when those are done |
@nathanhleung the Not sure if there are additional issues with npm 5.6.0 , but it works as intended on 6.2 when using the quotes. |
@MFry Interesting - didn't realize that. I'll run tests on different NPMs and see what happens. Thanks for letting me know. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
bump |
When running
install-peerdeps
the install will fail if the packages end in-0
.Version
OS: Windows 7
Reproduce
The issue occurs when the
install-peerdeps
evaluatese.x.
npm install enzyme-adapter-react-16@1.1.1 enzyme@^3.0.0 react@^16.0.0-0 react-dom@^16.0.0-0 --no-save
which will fail, but if you place the
react
andreact-dom
in quotation marks like:npm install enzyme-adapter-react-16@1.1.1 enzyme@^3.0.0 "react@^16.0.0-0" "react-dom@^16.0.0-0" --no-save
it will run successfully.
The text was updated successfully, but these errors were encountered: