[FIXED] Support multiple trusted operators using a config file #5896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Jarema
force-pushed
the
fix-operator-config-list
branch
from
780e6a3
to
0104407
Compare
neilalexander
requested changes
Sep 17, 2024
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
kozlovic
reviewed
Sep 17, 2024
| @@ -1286,6 +1286,22 @@ func (o *Options) processConfigFileLine(k string, v any, errors *[]error, warnin | |||
| opFiles = append(opFiles, v) | |||
| case []string: | |||
| opFiles = append(opFiles, v...) | |||
| case []any: | |||
There was a problem hiding this comment.
You could have a look at the helper parseStringArray(). That could simplify the case "operator" a bit, I think.
There was a problem hiding this comment.
@Jarema Do you want to look at using that helper or are we good as is?
wallyqs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5810
Signed-off-by: Tomasz Pietrek tomasz@nats.io