Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trie search Class #833

Closed
wants to merge 9 commits into from
Closed

Trie search Class #833

wants to merge 9 commits into from

Conversation

itsomkathe
Copy link
Contributor

Which issue does this refer to ?
Refer to #776

Brief description of the changes done

  1. Created a small class for searching in data using trie

@itsomkathe itsomkathe added the enhancement New feature or request label Dec 7, 2022
@itsomkathe itsomkathe self-assigned this Dec 7, 2022
@vercel
Copy link

vercel bot commented Dec 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
bhanwari-devi ✅ Ready (Inspect) Visit Preview Dec 8, 2022 at 0:48AM (UTC)
bhanwari-devi-old ✅ Ready (Inspect) Visit Preview Dec 8, 2022 at 0:48AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
meraki-dev ⬜️ Ignored (Inspect) Dec 8, 2022 at 0:48AM (UTC)

@jschanker
Copy link
Collaborator

@itsomkathe Sorry I didn't respond to #776 (comment) before. I wasn't sure if you had a question about this? But yes, you shouldn't need to install anything. If you create the files with those test.js extensions, you should be able to see whether they pass/fail in the Tests tab on CodeSandbox. You can also run them with react-scripts test. By adding these files, the GitHub action will automatically run them: https://github.com/navgurukul/bhanwari-devi/actions/runs/3640682178/jobs/6145682318#step:4:775 . One way to organize unit tests is to place them in the directory that the component is located in.

@komalahire komalahire changed the base branch from dev to volunteer-dashboard December 8, 2022 10:46
@itsomkathe
Copy link
Contributor Author

@itsomkathe Sorry I didn't respond to #776 (comment) before. I wasn't sure if you had a question about this? But yes, you shouldn't need to install anything. If you create the files with those test.js extensions, you should be able to see whether they pass/fail in the Tests tab on CodeSandbox. You can also run them with react-scripts test. By adding these files, the GitHub action will automatically run them: https://github.com/navgurukul/bhanwari-devi/actions/runs/3640682178/jobs/6145682318#step:4:775 . One way to organize unit tests is to place them in the directory that the component is located in.

Okay, I did now know it. I've written some tests. Will run it on sandbox and add it in the component directory. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants