This repository has been archived by the owner on Jun 10, 2024. It is now read-only.
Add NumberConversionTypePreference for strings #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petli
approved these changes
Mar 30, 2023
There was a problem hiding this comment.
Thanks for the submission! It is a bit curious that Numbers parsed strings as decimal, since the grammar always parsers numbers as doubles:
https://github.com/ncalc/ncalc-async/blob/master/src/Grammar/NCalc.g#L221
A potential problem with the conversion of strings to numbers is that double.Parse() or decimal.Parse() will use the current culture. It can also be a feature for some users. However, this have always been the case, so I don't think it needs to be addressed in this PR.
|
Published as v3.2.6: https://www.nuget.org/packages/NCalcAsync/3.2.6 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to convert string values to a double instead of a decimal. Doubles have more compatibility with other types so it is nice to have the option to convert a string to a double.