Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"No puzzle" issue solved, README updated #1

Merged
merged 8 commits into from
Jul 1, 2021
Merged

Conversation

volovyks
Copy link

@volovyks volovyks commented Jun 21, 2021

I have fixed my bug from the previous PR. So now it's a fully functional contract.
I don't like the design, we definitely should improve and simplify the way how we manage puzzles and their states.

P.S. @mikedotexe let's add Austin, Phoung, and other people to near-examples.

README.md Outdated Show resolved Hide resolved
@volovyks volovyks requested a review from mikedotexe June 21, 2021 13:41
Copy link

@MaximusHaximus MaximusHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, but if we delete private keys without asking the user I think we should prioritize killing that behavior ASAP

README.md Outdated Show resolved Hide resolved
contract/src/lib.rs Outdated Show resolved Hide resolved
Copy link

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably also don't need to commit the built wasm file too, but generally LGTM

README.md Outdated Show resolved Hide resolved
Copy link

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some other typo fixes, if you want

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@volovyks volovyks self-assigned this Jun 29, 2021
volovyks and others added 4 commits July 1, 2021 19:21
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Co-authored-by: Austin Abell <austinabell8@gmail.com>
@volovyks volovyks merged commit 2b11d10 into main Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants