Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEP-454 Multi Token Standard Royalties and Payouts #454

Closed
wants to merge 4 commits into from

Conversation

uncle-T0ny
Copy link

Those familiar with the NEP-199 payout interface for non-fungible tokens may expect a similar interface for multi token contracts.

@uncle-T0ny uncle-T0ny changed the title NEP-246 Multi Token Standard Royalties and Payouts NEP-454 Multi Token Standard Royalties and Payouts Jan 27, 2023
@frol frol added WG-contract-standards Contract Standards Work Group should be accountable S-draft/needs-moderator-review A NEP in the DRAFT stage that needs a moderator review. A-NEP A NEAR Enhancement Proposal (NEP). labels Feb 1, 2023
@ori-near ori-near added S-review/needs-wg-to-assign-sme A NEP that needs working group to assign two SMEs. and removed S-draft/needs-moderator-review A NEP in the DRAFT stage that needs a moderator review. labels Feb 14, 2023
@ori-near
Copy link
Contributor

Thank you @uncle-T0ny for submitting this NEP.

As a moderator, I reviewed this NEP and it meets the proposed template guidelines. I am moving this NEP to the REVIEW stage and would like to ask the @near/wg-contract-standards working group members to assign 2 Technical Reviewers to complete a technical review (see expectations). If you want to assign yourself, please mention that you are acting as the Technical Reviewers.

Please find some guidelines below for completing the technical review.

Technical Review Guidelines
  • First, review the proposal within one week. If you have any suggestions that could be fixed, leave them as comments to the author. It may take a couple of iterations to resolve any open comments.
  • Second, once all the suggestions are addressed, produce:
    • A recommendation for the working group if the NEP is ready for voting (it could be approving or rejecting recommendation)
    • A summary of benefits
    • A summary of concerns and blockers that were identified on the way and their status (some will be resolved, others dismissed, etc)
      Here is a nice example and a template for your convenience:
## Example
### Recommendation
Add recommendation
### Benefits
* Benefit
* Benefit
### Concerns
| # | Concern | Resolution | Status |
| - | - | - | - |   
| 1 | Concern | Resolution | Status |
| 2 | Concern | Resolution | Status |

Please tag the @near/nep-moderators once you are done, so we can move this NEP to the voting stage. Thanks again.

@frol
Copy link
Collaborator

frol commented Feb 15, 2023

As a Contract Standards WG member, I believe we should do two things before moving forward with reviewing this NEP:

  1. evaluate the necessity of the MT standard as a whole (I raised this question in the Contract Standards Community Group)
  2. evaluate the state of the other parts of the standard before we dive into Royalties and Payouts (we had an offline discussion with @uncle-T0ny today, and he might be able to prepare a summary of the gaps of the current MT standard and potentially post it on Gigs Board)

@ori-near ori-near added S-retracted A NEP that was retracted by the author or had no activity for over two months. and removed S-review/needs-wg-to-assign-sme A NEP that needs working group to assign two SMEs. labels May 22, 2023
@ori-near
Copy link
Contributor

As the moderator, I assume this PR is no longer active given that there was no activity for over two months. Therefore, I am closing it. If anyone is interested in reopening this PR, please submit a new one.

@ori-near ori-near closed this May 22, 2023
@alexastrum
Copy link

We're currently in the process of getting mt approved.
Royalties and Payouts should probably be part of that standard, rather than a separate NEP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-NEP A NEAR Enhancement Proposal (NEP). S-retracted A NEP that was retracted by the author or had no activity for over two months. WG-contract-standards Contract Standards Work Group should be accountable
Projects
Status: RETRACTED
Development

Successfully merging this pull request may close these issues.

4 participants