Commits on Feb 3, 2022

1. Tweak enum serialization to generate better LLVM IR and more compact … …

   …code
   
   Change enum serialization form
   
     match self {
       Enum::Variant1(field1, field2, ...) => {
           // serialize variant idx
           let variant_idx: u8 = 0;
           writer.write_all(&variant_idx.to_le_bytes())?;
   
           // serialize variant fields
           BorshSerialize::serialize(field1, writer)?;
           BorshSerialize::serialize(field2, writer)?;
           ...
       }
       Enum::Variant2(field1, field2, ...) => {
           let variant_idx: u8 = 1;
           writer.write_all(&variant_idx.to_le_bytes())?;
   
           // serialize variant fields
           BorshSerialize::serialize(field1, writer)?;
           BorshSerialize::serialize(field2, writer)?;
           ...
   
       }
       ...
     }
   
   To:
   
     let variant_idx: u8 = match self {
       Enum::Variant1(..) => 0,
       Enum::Variant2(..) => 1,
       ...
     };
     // serialize variant_idx
     writer.write_all(&variant_idx.to_le_bytes())?;
   
     match self {
       Enum::Variant1(field1, field2, ...) => {
           // serialize variant fields
           BorshSerialize::serialize(field1, writer)?;
           BorshSerialize::serialize(field2, writer)?;
           ...
       }
       Enum::Variant2(field1, field2, ...) => {
           // serialize variant fields
           BorshSerialize::serialize(field1, writer)?;
           BorshSerialize::serialize(field2, writer)?;
           ...
   
       }
       ...
     }
   
   The latter generates better LLVM IR, and avoids
   writer.write_all(&variant_idx.to_le_bytes())?; from being inlined into each
   match branch.

   

   alessandrod committed Feb 3, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 62eb134
   • Browse repository at this point

   Copy the full SHA

   62eb134 View commit details

   Browse the repository at this point in the history