Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account ID pre-validation #326

Open
ilblackdragon opened this issue Apr 24, 2020 · 0 comments
Open

Account ID pre-validation #326

ilblackdragon opened this issue Apr 24, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request T-dev-tools

Comments

@ilblackdragon
Copy link
Member

ilblackdragon commented Apr 24, 2020

Right now we don't validate anything about account ids before creating transaction.
We can check:

  • this is valid format for an account id (lowercase, no extra characters) and pint human error for that
  • if account doesn't exist on the blockchain (even if key is in the keystore)
  • any other checks

Note, it's especially true if people call near generate-key <account_Id> or if people manually copy / modify account id in the key file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request T-dev-tools
Projects
None yet
Development

No branches or pull requests

4 participants