-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve messages for generate-key
#786
Comments
Ditto. This seems like very poor wording... Although yes, the account does JUST NOW after running the generate-key command, have an "existing" key pair... but existing in this context makes it seem like a different key pair existed before the command was run. Maybe something along the lines of "Key pair has been generated" or some such... This should be a relatively easy fix... anyone able to provide feedback on different verbiage? |
I'm new to Near development and just encountered this in the CLI. It was very confusing, as the account doesn't even exist on the blockchain yet (just used some random unique name)- and I was generating a key for the first time from a random seed phrase. It was even more confusing, because just before this I had used a seed phrase with an account that does exist (but wasn't in my local |
When we run
near generate key <accId> --seedPhease=<seed>
we are always gettingAccount has existing key pair with ed25519:<pk> public key
. It happens even when account Id and pk are not in our local storage.Another issue:
When we run simple
near generate-key <acc-name>
we are gettingKey pair with ed25519:<pk> public key for an account "<acc>"
which is not very informative. Let's explain user where this key is stored.Another issue:
When the key is already stored - we are getting the same message
Account has existing key pair with XXX
, but the existing key is replaced with the generated one. So.. the user can lose his private key. The user should be prompted that the key will be overwriteen.The text was updated successfully, but these errors were encountered: