-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent plugin dependencies in "omit" from causing already-imported warnings #1044
Prevent plugin dependencies in "omit" from causing already-imported warnings #1044
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1044 +/- ##
==========================================
- Coverage 93.97% 93.95% -0.03%
==========================================
Files 179 179
Lines 25140 25164 +24
Branches 2613 2615 +2
==========================================
+ Hits 23626 23642 +16
- Misses 1210 1218 +8
Partials 304 304
Continue to review full report at Codecov.
|
42928bf
to
8176aea
Compare
Sorry, this has taken a while to get to. Thanks for providing a test! But I tried running the test without your fix, and it didn't fail. Does it fail for you? |
cbfffc4
to
278f54b
Compare
Sorry about that, I was probably blindly chasing coverage 😄 I've added a new failing test case, you can see it fail with the |
Ugh, I'm sorry, I forgot you had fixed this problem. I fixed it in a different way for #1150. Does it solve the problem for you? |
0c14f1a
to
82169a6
Compare
Since there has been no response, are we good to close this? |
Apologies for keeping this open, if I recall correctly I think I had found a different workaround by changing which options I was using and forgot to test the new fix. I'll close now |
I came across the same bug noted in this comment when using django plugin alongside both source/include and omit would cause a bunch of already-imported warnings for the plugin's dependencies:
I tried to fix this from the plugin side, but the only place the plugin gets an opinion is in the plugin's
file_tracer()
method, and we can't disable tracing for the core django templates, otherwise we can't trace the templates themselves.Every other
omit_match
check is used too late, after plugins have already imported their dependencies