Support patterns in module names #917
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if you agree in principle with the changes in the PR and I will also update the documentation accordingly. |
|
@nedbat Any chance of getting this PR approved? |
|
Hi, sorry that I let this get so old. Can you tell me more about the problem you are solving with this change? |
|
We are using one framework, which generates code in temporary modules on the fly, so in case we want to measure the code coverage of the generated modules (we do), we need a way to match the dynamic module names. |
kvalev
force-pushed
the
module-name-pattern
branch
from
94aeafa
to
44e2fec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for using patterns in the
sourcemodule names. For example the following configuration will match both thecoverage, as well as themycoveragemodules: