Merge pull request #4 from arjanvdbos/fix-deprecated-factory-constructor

Fix GelfHandlerFactory to be compatible with ServiceManager v3
neeckeloo · Sep 22, 2016 · 25bec64 · 25bec64
2 parents 237c9ac + f0de339
commit 25bec64
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/src/Handler/Factory/GelfHandlerFactory.php b/src/Handler/Factory/GelfHandlerFactory.php
@@ -19,13 +19,21 @@ class GelfHandlerFactory implements FactoryInterface
     /**
      * @param array $options
      */
-    public function __construct(array $options)
+    public function __construct(array $options = [])
     {
+        // Zend ServiceManager v2 allows factory creationOptions
         $this->options = $options;
     }
 
     public function __invoke(ContainerInterface $container, $requestedName, array $options = null)
     {
+        /**
+         * Avoid a BC break; Zend ServiceManager v2 will pass the options via the constructor, v3 to the __invoke()
+         */
+        if (null !== $options) {
+            $this->options = array_merge($this->options, $options);
+        }
+
         if (!isset($this->options['host'])) {
             throw new Exception\RuntimeException('Gelf handler needs a host value');
         }

diff --git a/tests/Handler/Factory/GelfHandlerFactoryTest.php b/tests/Handler/Factory/GelfHandlerFactoryTest.php
@@ -21,6 +21,23 @@ public function testInstantiateGelfHandler()
         $this->assertInstanceOf(GelfHandler::class, $gelfHandler);
     }
 
+    public function testInstantiateGelfHandlerViaInvokeOptions()
+    {
+        $serviceLocator = $this->createMock(ServiceLocatorInterface::class);
+
+        $gelfHandlerFactory = new GelfHandlerFactory();
+        $gelfHandler = $gelfHandlerFactory->__invoke(
+            $serviceLocator,
+            GelfHandler::class,
+            [
+                'host' => 'domain.com',
+                'port' => 123,
+            ]
+        );
+
+        $this->assertInstanceOf(GelfHandler::class, $gelfHandler);
+    }
+
     /**
      * @expectedException \MonologModule\Exception\RuntimeException
      */