Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ML API procedures handle null values being passed in better #3611

Closed
jexp opened this issue Jun 5, 2023 · 0 comments
Closed

ML API procedures handle null values being passed in better #3611

jexp opened this issue Jun 5, 2023 · 0 comments

Comments

@jexp
Copy link
Member

jexp commented Jun 5, 2023

If you construct a string and one of the values (e.g. movie.plot) is null the whole string will be null, which currently causes the api call to also fail with a 400 error, that’s why currently one has to use coalesce functions.

But we should probably just filter those out in the embeddings call and don't forward them and return the result row with a null value for embedding.

For the other ml api calls, we might just want to return a null value for a null input or create an exception upfront so that the user knows what went wrong.

Should probably also look into better exposing http error messages in the loadJson() function, currently they are not passed along in the error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done (to cherry-pick)
Development

No branches or pull requests

1 participant