Add multi-database support #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API is changed to leverage object destructuring, so that we have named arguments and default values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds multi-database support for the driver against a multi-database supporting database. A session is operating against a database which can be selected while creating the session object through
driver.sessioncall. The default database is set to be an empty string''and connects to the default database as set on the database.API Changes
driver.sessionfunction signature is now changed in a breaking manner. The new signature includes an object destructuring construct where you can now pass parameters by name.While previously the parameters were positional, like
const session = driver.session(WRITE, bookmark),now it has been changed like
const session = driver.session({ defaultAccessMode: WRITE, bookmark: bookmark, db: db })