Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch and improve the Docker deployment process #144

Merged
merged 3 commits into from
Jul 11, 2023

Conversation

neon-mmd
Copy link
Owner

What does this PR do?

This PR adds improvements and fixes to the Dockerfile.

Why is this change important?

This change improves the Dockerfile according to the GitHub action as well as fixes it so that it can run again without any errors.

How to test this PR locally?

To test this PR locally, just clone the repository and change the directory to the cloned repository folder (project folder/codebase) and then checkout the branch patch-and-improve-dockerfile and then run the command docker compose up -d --build

Putting it altogether:

git clone https://github.com/neon-mmd/websurfx.git
cd websurfx
git checkout patch-and-improve-dockerfile
docker compose up -d --build

Author's checklist

  • add fixes and improvements to the dockerfile.
  • bump the app version.

Related issues

Closes #143

@github-actions
Copy link

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
❌ ACTION actionlint 7 1 0.05s
❌ CSS stylelint 13 6 1 1.24s
❌ DOCKERFILE hadolint 1 1 0.07s
❌ HTML djlint 13 8 0.63s
⚠️ MARKDOWN markdownlint 14 6 42 1.13s
❌ RUST clippy yes 1 64.77s
❌ SPELL cspell 73 248 26.25s
❌ YAML yamllint 11 1 0.29s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@github-actions
Copy link

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
❌ ACTION actionlint 7 1 0.05s
❌ CSS stylelint 13 6 1 1.3s
❌ DOCKERFILE hadolint 1 1 0.07s
❌ HTML djlint 13 8 0.62s
⚠️ MARKDOWN markdownlint 14 6 42 1.16s
❌ RUST clippy yes 1 65.55s
❌ SPELL cspell 73 248 25.06s
❌ YAML yamllint 11 1 0.47s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Collaborator

@alamin655 alamin655 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Let's merge this in. 👍

@alamin655 alamin655 merged commit e4625c3 into rolling Jul 11, 2023
4 of 6 checks passed
@alamin655 alamin655 deleted the patch-and-improve-dockerfile branch July 11, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Patch and improve Docker deployment process
2 participants