-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📜 Revise the docs
to remain in sync with the current changes
#151
Conversation
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just one small issue needs to be fixed
If you don't mind can you kindly commit this suggestion from your side if possible 🙂 because I am abroad for 9-10 days so I might not be able to do so.
…On July 19, 2023 12:54:46 AM UTC, zhou fan ***@***.***> wrote:
@xffxff approved this pull request.
Looks good to me, just one small issue needs to be fixed
> @@ -36,14 +37,17 @@ Some of the configuration options provided in the file are stated below. These a
> By Default we provide 9 colorschemes to choose from these are:
We currently provide 12 themes
--
Reply to this email directly or view it on GitHub:
#151 (review)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
Sure, no problem. Wishing you a pleasant journey. |
What does this PR do?
This PR updates the
docs
for the project by updating the names of the previous config options and adding and explaining new config option proposed in PR #145 and also updates the explanation of the colorscheme option.Why is this change important?
This change is essential as it ensures that the
docs
remain in sync with the current changes.Author's checklist
redis_connection_url
config option.upstream_search_engines
with the explanation.colorscheme
.Related issues
Closes #148