Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation patch #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Documentation patch #6

wants to merge 2 commits into from

Conversation

skotchvail
Copy link

Fixed some warnings I was getting about

  • parameter 'startSelector' is already documented
  • Parameter 'direction' not found in the function declaration
  • /FTAnimationManager.m:67:1: Property is assumed atomic by default
  • /FTUtils+UIGestureRecognizer.h:92:7: No newline at end of file

I forked from Strilanc/ftutils's patch which fixes:

  • /FTUtils+UIGestureRecognizer.m:52:1: Category is implementing a method which will also be implemented by its primary class

Strilanc and others added 2 commits November 18, 2013 17:44
@Strilanc
Fixed 'implementing a method which will also be implemented by its pr…
e439dde 
…imary class' warning

The 'handleAction' method was declared in UIGestureRecognizer+'' but implemented by UIGestureRecognizer+FTBlockAdditions

I fixed the warning by removing the apparently spurious declaration, and also the whole UIGestureRecognizer+'' declaration since it only had the one declaration and is not implemented anywhere.
Fixed warnings related to incorrect documentation parameters
d4b02a3 
Also explicitly made property atomic, since the compiler was assuming as much
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skotchvail @Strilanc