Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): add bigint to built-in types #2080

Merged

Conversation

esahin90
Copy link
Contributor

See: https://mongoosejs.com/docs/schematypes.html#bigint

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

BigInt is not supported as a primitive type

What is the new behavior?

BigInt is supported by mongoose and will be supported here as well with these changes

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@esahin90 esahin90 force-pushed the feature/add-primitive-type-bigint branch from 42a9afa to 0b2a908 Compare March 11, 2024 08:44
@esahin90 esahin90 changed the title feat: add bigint to built-in types feat(): add bigint to built-in types Mar 11, 2024
@esahin90
Copy link
Contributor Author

Hey @kamilmysliwiec
Would appreciate it, if you have some time for a little review for a pretty small code change :)
Best regards,
Emre

@nhayhoc
Copy link

nhayhoc commented Apr 1, 2024

I hope it gets updated soon

@esahin90
Copy link
Contributor Author

esahin90 commented Apr 2, 2024

@nhayhoc I‘m using patch-package to patch the node_modules locally and make it work for now as a workaround.

@kamilmysliwiec
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants