Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ws): filter only nil results #11186

Merged

Conversation

CodyTseng
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

If the message handler return false, the ws-adapter will filter this result.

What is the new behavior?

Only nil results will be filtered. This behavior is the same as io-adapter.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

By the way, I don't think null should be filtered 🤔.

@CodyTseng CodyTseng changed the title fix(ws): filter non nil result fix(ws): filter only nil results Mar 3, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 897ec688-b228-40a3-9dc1-fc6fb90f5c52

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.885%

Totals Coverage Status
Change from base Build 5e72b472-ecc8-4d1e-a9fd-634e8558b976: 0.0%
Covered Lines: 6488
Relevant Lines: 6985

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants