Skip to content

Commit

Permalink
Merge pull request #12 from msherif1234/latest
Browse files Browse the repository at this point in the history
install golangci-lint only if its not installed and update readme
  • Loading branch information
jpinsonneau committed Mar 26, 2024
2 parents 4378f6b + f58b119 commit 9e16a1c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
2 changes: 2 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,9 @@ prepare:
.PHONY: prereqs
prereqs: ## Test if prerequisites are met, and installing missing dependencies
@echo "### Test if prerequisites are met, and installing missing dependencies"
ifeq (, $(shell which golangci-lint))
GOFLAGS="" go install github.com/golangci/golangci-lint/cmd/golangci-lint@${GOLANGCI_LINT_VERSION}
endif

.PHONY: vendors
vendors: ## Refresh vendors directory.
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ This will also copy resources and oc commands to the `build` directory.
Simply run the following command to start capturing flows:

```bash
./build/oc-netobserv-flows
./oc/oc-netobserv-flows
```

![flows](./img/flow-table.png)
Expand All @@ -65,13 +65,13 @@ To stop capturing press Ctrl-C.
PCAP generated files are compatible with Wireshark

```bash
./build/oc-netobserv-packets <filters>
./oc/oc-netobserv-packets <filters>
```

For example:

```bash
./build/oc-netobserv-packets "tcp,8080"
./oc/oc-netobserv-packets "tcp,8080"
```

![packets](./img/packet-table.png)
Expand All @@ -84,7 +84,7 @@ To stop capturing press Ctrl-C.
The `cleanup` function will automatically remove the eBPF programs when the CLI exits. However you may need to run it manually if an error occurs.

```bash
./build/oc-netobserv-cleanup
./oc/oc-netobserv-cleanup
```

## Extending OpenShift CLI with plugin
Expand Down

0 comments on commit 9e16a1c

Please sign in to comment.