Remove bash trace and manage unbound var #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msherif1234
reviewed
Mar 15, 2024
| echo "Filters not set" | ||
| else | ||
| echo "Filters set as $1" | ||
| filter=$1 |
There was a problem hiding this comment.
I don't set it directly:
- Line 5 to avoid bash to fail if not set
- Line 7 checks if the variable exists without failing
- Line 12 set the variable (only if it exists)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
functions.shis called from oc commands, we need to adapt the scripts to ensure variables are bound.Else the scripts simply crash when filters are not set:
Also removed trace since it makes difficult to read the custom messages that are supposed to guide you.