Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hidden states and scores not being returned #18

Merged
merged 2 commits into from
Jul 22, 2023

Conversation

nightingal3
Copy link
Contributor

I tried to get hidden states and scores from llama the other day but they weren't being returned. I think this is because of the arguments being overridden when there's a string input.

To test, do outputs = client.prompt("hello", output_scores=True, output_hidden_states=True). You should see scores and hidden states.

@nightingal3 nightingal3 requested a review from urialon July 9, 2023 19:57
Copy link
Contributor

@urialon urialon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but assigning @CoderPat because I'm not really involved

@nightingal3 nightingal3 merged commit f158d06 into main Jul 22, 2023
2 checks passed
@nightingal3 nightingal3 deleted the fix-hidden-states-bug branch July 22, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants