Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Signed Builds #3

Open
garrettmflynn opened this issue Nov 16, 2023 · 1 comment
Open

Fix Signed Builds #3

garrettmflynn opened this issue Nov 16, 2023 · 1 comment
Assignees

Comments

@garrettmflynn
Copy link
Member

Builds break immediately after being signed—specifically on Mac M2. Including identity: null fixes this problem—but, in the long run, will result in an inability to create applications that can be widely shared.

One possible solution is to dynamically add the identity: null declaration if the conditions for notarization aren't met on Mac, though we'll first have to check that proper notarization fixes this problem in the first place.

@garrettmflynn garrettmflynn self-assigned this Nov 16, 2023
@garrettmflynn
Copy link
Member Author

For further context, this also happens on my Intel Mac, though this throws a CSSMER_TP_CERT_REVOKED error that results in the same The application "X" can't be opened error appearing when the app is opened.

These resources may be helpful for resolving this issue on systems running MacOS:

  1. Correct way to Code Signing on macOS electron-userland/electron-builder#1046
  2. Unable to code sign non-MAS build with "Mac Developer: " cert electron-userland/electron-builder#6564

This is avoided on the commoners-starter-kit because the process:

skipped macOS application code signing  reason=cannot find valid "Developer ID Application" identity or custom non-Apple code signing certificate, it could cause some undefined behaviour, e.g. macOS localized description not visible, see https://electron.build/code-signing allIdentities=     0 identities found

So at least for Github Actions, this can be subverted by setting secrets like APPLE_DEVELOPER_ID_IDENTITY_HASH, APPLE_DEVELOPER_ID_NAME, APPLE_ID, APPLE_PASSWORD, MACOS_CERTIFICATE, and MACOS_CERTIFICATE_PWD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant