Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to code sign non-MAS build with "Mac Developer: " cert #6564

Closed
regentcid434 opened this issue Jan 18, 2022 · 3 comments · Fixed by #6956
Closed

Unable to code sign non-MAS build with "Mac Developer: " cert #6564

regentcid434 opened this issue Jan 18, 2022 · 3 comments · Fixed by #6956

Comments

@regentcid434
Copy link
Contributor

  • Electron-Builder Version: ^22.11.9
  • Node Version: 16.5.0
  • Electron Version: 15.1.0
  • Target: dmg

Starting with version 22.11.9 the code signing step of my build is being skipped when using my "Mac Development" cert with the following message:

• skipped macOS application code signing  reason=cannot find valid "Developer ID Application" identity or custom non-Apple code signing certificate, see https://electron.build/code-signing allIdentities=  1) B25E56392217F01EF30D96178C7E101386F779DE "Mac Developer: Cody Callahan (2H2S3FF89J)"
     1 identities found
                                                Valid identities only
  1) B25E56392217F01EF30D96178C7E101386F779DE "Mac Developer: Cody Callahan (2H2S3FF89J)"
     1 valid identities found

In my .env file, I'm setting CSC_NAME="Mac Developer: Cody Callahan (2H2S3FF89J)". After digging through the source, I found that it's ignoring "Mac Developer" certificate types unless the build is for the Mac App Store. 4a177dc added an isMas check for development builds in getCertificateTypes which will default to "Developer ID Application" when false. This was added to address #6094, but this side effect seems unintentional. Can we add "Mac Developer" to the second array in the ternary?

@stale
Copy link

stale bot commented Apr 16, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Apr 16, 2022
@regentcid434
Copy link
Contributor Author

This is still relevant. It looks like #6621 also has an issue signing, albeit with a 3rd party cert.

@stale stale bot removed the backlog label Apr 19, 2022
@regentcid434
Copy link
Contributor Author

Is there any reason not to add this back? I can open a PR.

regentcid434 added a commit to regentcid434/electron-builder that referenced this issue Jun 21, 2022
Mac Developer certificates can be used to code sign when not building for the Mac App Store

fixes electron-userland#6564
mmaietta pushed a commit that referenced this issue Jun 21, 2022
Mac Developer certificates can be used to code sign when not building for the Mac App Store. Fixes #6564
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant