Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented Basic Auth #6

Merged
merged 24 commits into from
Sep 5, 2018
Merged

Implemented Basic Auth #6

merged 24 commits into from
Sep 5, 2018

Conversation

dalazx
Copy link
Contributor

@dalazx dalazx commented Aug 31, 2018 •
edited
Loading

Fixes #2

@dalazx dalazx added the WIP Work in progress label Aug 31, 2018
@dalazx dalazx changed the title [WIP] Added a dummy auth middleware [WIP] Implemented Basic Auth Sep 4, 2018
@dalazx
Copy link
Contributor Author

dalazx commented Sep 4, 2018

related aio-libs/aiohttp#3239

@dalazx dalazx changed the title [WIP] Implemented Basic Auth Implemented Basic Auth Sep 4, 2018
@dalazx dalazx removed the WIP Work in progress label Sep 4, 2018
@dalazx
Copy link
Contributor Author

dalazx commented Sep 4, 2018

@asvetlov @zubrabubra please take a look. this is a bare minimum we need until the auth/user micro service with ACL is implemented.

@dalazx
Copy link
Contributor Author

dalazx commented Sep 5, 2018

thanks folks

@dalazx dalazx merged commit f341e1c into master Sep 5, 2018
@dalazx dalazx deleted the basic_auth branch September 5, 2018 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@zubrabubra zubrabubra zubrabubra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dalazx @asvetlov @zubrabubra