-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Traditional Chinese (zh-Hant) translation #198
Update Traditional Chinese (zh-Hant) translation #198
Conversation
...AdvancedPreferencesViewController/zh-Hant.lproj/KYAAdvancedPreferencesViewController.strings
Outdated
Show resolved
Hide resolved
...YABatteryPreferencesViewController/zh-Hant.lproj/KYABatteryPreferencesViewController.strings
Show resolved
Hide resolved
I like names of different modes like 韜光養晦. It gives me an aesthetic feeling. These names elevate the translation. |
Very nice effort, thank you 🙂👍. I will be happy to merge this when it's ready. As an optional hint, you can alternatively just work with the XLIFF files directly (e.g. in I use these to import/export the translations into the *.strings files whenever there are changes or when new Xcode versions are available. But in the end I also don't mind if the *.strings files are edited as well ^^… makes is probably easier for you to test. Thanks! |
@@ -1,12 +1,12 @@ | |||
{ | |||
"developmentRegion" : "en", | |||
"project" : "KeepingYouAwake.xcodeproj", | |||
"targetLocale" : "zh-Hant-TW", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an automatic change by Xcode or was it simply not properly set up before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I change to use zh-Hant instead of zh-Hant-TW, as there is no other Hant translation currently.
If someone adds another zh-Hant translation (e.g., zh-Hant-HK), I will update this translation to zh-Hant-TW then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized that I forgot to remove the old translation files, removed in 7b60b2d.
Hi @newmarcel, thanks for the hint, here's the story. Initially, I only updated the xliff file, but I encountered some issues:
As a result, I decided to build the app in Xcode and see what was going on. And decided to clean up the zh-Hant translation by regenerating the strings files, translating them, and exporting them to xliff. Hope these changes won't require you to do any additional work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice!
Thanks @YuerLee for the explanations 👍. I also very much appreciate the work and discussions that went into this PR and I'm very happy to just merge it 😺 Thanks everyone! |
Hi, I updated the Traditional Chinese:
zh-Hant
instead ofzh-Hant-TW
, as there is no other Hant translation currently.斟滿
foractivate
and清空杯子
fordeactivate
.