-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor improvements to French translation #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two small formatting issues, but overall I am ok with these changes despite my limited knowledge of French 😉
@@ -32,4 +32,3 @@ Click droit pour le menu"; | |||
|
|||
/* Version */ | |||
"Version" = "Version"; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally prefer having a empty line at the end of source and .strings
files.
@@ -72,4 +72,3 @@ | |||
|
|||
/* Class = "NSTextFieldCell"; title = "Automatically opens the app when you start your Mac."; ObjectID = "x6s-XD-lBU"; */ | |||
"x6s-XD-lBU.title" = "Lance KeepingYouAwake au démarrage du Mac."; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the empty line at the end of the file.
as requested
Hi @newmarcel , added the missing empty line. Hope this is what you are looking for. (sorry if I did it wrong, first time I modify a merge request) Take care -- Alex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this. Approved 👍
Can you resolve the merge conflict? I will merge this afterwards.
@newmarcel I can't resolve the conflict myself unless you give me write access to the repository. The warning message I get is:
Our options, as far as I know, are (A) you resolve the conflict or (B) you grant me write access. Thx :-) -- Alex |
OK, no problem, I will pull your commits directly into |
I've integrated both commits into |
No description provided.