Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versioned testing / confirm working with Hapi 20.x #771

Closed
michaelgoin opened this issue May 28, 2021 · 0 comments · Fixed by #819
Closed

Add versioned testing / confirm working with Hapi 20.x #771

michaelgoin opened this issue May 28, 2021 · 0 comments · Fixed by #819
Assignees

Comments

@michaelgoin
Copy link
Member

Looks like our versioned tests capped out at Hapi 18.x.

19 and 20 seem to fail with the existing tests. This is very likely due to breaking changes in the major version bump. We should get tests at least working with 20 (19 is deprecated).

Since it is untested, there's a chance we may have instrumentation issues too. Nothing has come up yet, though. If something is found and it is a quick fix, then we can just resolve on the spot. If going to be a larger effort, then we can discuss a plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants