Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hapi 19 20 #819

Merged
merged 2 commits into from
Jul 22, 2021
Merged

Add hapi 19 20 #819

merged 2 commits into from
Jul 22, 2021

Conversation

bizob2828
Copy link
Member

@bizob2828 bizob2828 commented Jul 22, 2021

Proposed Release Notes

  • Added hapi 19 and 20 to versioned tests for Node.js >=12 and <16
  • Added hapi ^20.1.2 to versioned tests for for Node.js >=16

Links

Closes #771

Details

Hapi 19 and <20.1.2 crashes on Node.js 16 because of hapijs/hapi#4208. They fixed this and shipped a release in 20.1.2: hapijs/hapi#4225 (comment).

@michaelgoin michaelgoin added risk: low This change does not impact critical areas of the code and is expected to have minimal risk. semver: minor New features added. labels Jul 22, 2021
Copy link
Member

@michaelgoin michaelgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michaelgoin michaelgoin merged commit f137362 into newrelic:main Jul 22, 2021
@github-actions github-actions bot mentioned this pull request Jul 26, 2021
@bizob2828 bizob2828 deleted the add-hapi-19-20 branch August 28, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
risk: low This change does not impact critical areas of the code and is expected to have minimal risk. semver: minor New features added.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add versioned testing / confirm working with Hapi 20.x
2 participants