Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not change css class names when building #694

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Do not change css class names when building #694

merged 1 commit into from
Nov 2, 2022

Conversation

skjnldsv
Copy link
Contributor

Glad we did some beta lol, it seems module do some weird stuff

Before After
image image

Ref nextcloud/server#34868

@skjnldsv
Do not change css class names when building
f9a8fa7 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv self-assigned this Oct 28, 2022
@skjnldsv skjnldsv added the bug Something isn't working label Oct 28, 2022
@skjnldsv skjnldsv mentioned this pull request Oct 28, 2022
Merged
1 task
@skjnldsv
Copy link
Contributor Author

skjnldsv commented Nov 2, 2022 •
edited
Loading

Bump please so we can fix server 😁

ChristophWurst
ChristophWurst approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind shedding some light on why esm broke this and how your patch fixes this?

👍 🐘

@skjnldsv
Copy link
Contributor Author

skjnldsv commented Nov 2, 2022 •
edited
Loading

Mind shedding some light on why esm broke this and how your patch fixes this?

esm is not needed, the module:true is what caused it.
Keep in mind this is a followup to the beta changes and the scss compilation recently added from #691

#691 was part of the answer on how to properly compile scss with rollup.
This pr is the last missing part

@skjnldsv skjnldsv merged commit 66b7763 into master Nov 2, 2022
@skjnldsv skjnldsv deleted the fix/css-module branch November 2, 2022 09:15
@ChristophWurst
Copy link
Contributor

Ok but I still can't follow.

@skjnldsv skjnldsv mentioned this pull request Nov 2, 2022
Merged
@skjnldsv
Copy link
Contributor Author

skjnldsv commented Nov 2, 2022

Ok but I still can't follow.

This is about the scss->css compilation, no about the js bundles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@szaimen szaimen szaimen approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

@skjnldsv skjnldsv

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @ChristophWurst @szaimen