Skip to content

Commit

Permalink
fix(NcHeaderMenu): Remove padding from popover menu
Browse files Browse the repository at this point in the history
There should be no padding within the popover menu.
The popover container is not styleable (at least not without hacking the (not exposed-)CSS classes),
so users can not remove the padding themself.

The padding is a problem if the content is scrollable,
because the scrollbar should be on the very end of the container and not floating around.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
  • Loading branch information
susnux committed Aug 29, 2024
1 parent 47e15cd commit 093095e
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions src/components/NcHeaderMenu/NcHeaderMenu.vue
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,11 @@ $externalMargin: 8px;
// header is filled with primary or image background
filter: none !important;
color: var(--color-background-plain-text, var(--color-primary-text)) !important;
&:focus-visible {
outline: none !important;
box-shadow: none !important;
}
}
&--opened &__trigger,
Expand All @@ -350,19 +355,13 @@ $externalMargin: 8px;
opacity: 1;
}
#{&}__trigger:focus-visible {
outline: none !important;
box-shadow: none !important;
}
&__wrapper {
position: fixed;
z-index: 2000;
top: var(--header-height);
inset-inline-end: 0;
box-sizing: border-box;
margin: 0 $externalMargin;
padding: 8px;
border-radius: 0 0 var(--border-radius) var(--border-radius);
border-radius: var(--border-radius-large);
background-color: var(--color-main-background);
Expand Down

0 comments on commit 093095e

Please sign in to comment.