-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uploading & downloading of the AppAPI Apps #1145
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
bigcat88
added
enhancement
high priority
python
Pull requests that update Python code
3. to review
labels
Sep 21, 2023
Signed-off-by: Alexander Piskun <13381981+bigcat88@users.noreply.github.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
bigcat88
added a commit
to cloud-py-api/nc_py_api
that referenced
this pull request
Sep 28, 2023
### Added - NextcloudApp: The `ex_app.verify_version` function to simply check whether the application has been updated. ### Changed - NextcloudApp: Updated `info.xml` in examples to reflect upcoming changes in the [AppStore](nextcloud/appstore#1145) --- Hopefully, starting from this version there will be availability to upload applications into the AppStore(will be in beta stage) Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
andrey18106
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new endpoint for uploading all applications to the AppAPI.
Notable changes to existing methods:
In theory, these changes shouldn't disrupt existing functionality.
Applications developed for AppAPI reside in the same table as regular ones. Additionally, two new fields have been introduced to the releases table. One of these fields, labeled 'aa_proto', signifies if a release is part of the AppAPI ecosystem.
Furthermore, two new tables related to releases have been incorporated: 'AppApiReleaseApiScope' and 'AppApiReleaseDeployMethod'.
The 'AppApiReleaseApiScope' model defines the APIs an application will utilize, while the 'AppApiReleaseDeployMethod' model specifies the types of deployment methods the application supports.
There's a distinction in the endpoints when it comes to retrieving data: existing standard endpoints won't fetch applications linked to AppAPI. In contrast, the new endpoint is dedicated solely to returning AppAPI-associated applications.
The procedure for loading applications into the AppStore remains standard. Both types of applications use the same entry point.
Efforts were made to keep the number of changes minimal to prevent any potential disruptions.
The modifications mainly involve restructuring sentences for clarity and coherence.