Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add packaging capability to Mac Crafter #7173

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Add packaging capability to Mac Crafter #7173

wants to merge 14 commits into from
+224 −5

Conversation

claucambra
Copy link
Collaborator

Adds the ability to create a pkg directly from mac crafter

@claucambra
Add buildPackage function to mac crafter
9c841e8 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Add flag to build pkg in mac-crafter
7709d37 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Add ability to sign pkg from mac-crafter
13eeefd 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Add ability to notarise package from mac-crafter
8a8671d 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Add ability to build and sign sparkle tbz from mac-crafter
7586155 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Add logging to packaging procedures in mac-crafter
0a2d5d9 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Use appName for packaging step in mac-crafter
4bfb167 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Remove unused sparkleFile var
275b135 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Fix work build path used in mac crafter packaging stage
1365ee9 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Create convenience function to convert architecture string to craft t…
64ffc28 
…arget string

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Move packaging procedures into a single function in mac crafter
ec0a373 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Make specific step functions for packaging fileprivate in mac crafter
6b10a36 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Add package command for mac crafter
1597b8e 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra claucambra self-assigned this Sep 20, 2024
@claucambra
Add note about packaging tooling in mac crafter
7b63479 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7173-7b634795bc2ed3a8fef21bd9021d5d5fbed8d576-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien Awaiting requested review from mgallien

@camilasan camilasan Awaiting requested review from camilasan

At least 1 approving review is required to merge this pull request.

Assignees

@claucambra claucambra

Labels
os: 🍎 macOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@claucambra @nextcloud-desktop-bot