Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chat): Outline the participant count when trying to mention ever… #12782

Merged
merged 1 commit into from
Jul 23, 2024
Merged

feat(chat): Outline the participant count when trying to mention ever… #12782

merged 1 commit into from
Jul 23, 2024

Conversation

nickvergessen
Copy link
Member

…yone

☑️ Resolves

grafik

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added this to the 💙 Next Major (30) milestone Jul 23, 2024
@nickvergessen nickvergessen self-assigned this Jul 23, 2024
jancborchardt
jancborchardt approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Hopefully less notification spam on one side, and less embarrassment on the other :)

@nickvergessen nickvergessen force-pushed the bugfix/noid/outline-the-all-count branch 2 times, most recently from 672046e to e517145 Compare July 23, 2024 11:03
Antreesy
Antreesy approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickvergessen
Copy link
Member Author

nickvergessen commented Jul 23, 2024 •
edited
Loading

Let's wait for:

@nickvergessen
feat(chat): Outline the participant count when trying to mention ever…
e75a811 
…yone

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/outline-the-all-count branch from e517145 to e75a811 Compare July 23, 2024 13:32
@nickvergessen nickvergessen merged commit 78f4009 into main Jul 23, 2024
67 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/outline-the-all-count branch July 23, 2024 13:48
@SystemKeeper SystemKeeper mentioned this pull request Jul 23, 2024
Merged
@danxuliu danxuliu mentioned this pull request Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@Antreesy Antreesy Antreesy approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review enhancement feature: chat 💬 Chat and system messages
Projects
🖍 Design team
Status: 🎉 Done
Milestone
v20.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @jancborchardt @AndyScherzinger @Antreesy