fix: When banning a user they are also removed from the room #12821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
2. developing
bug
feature: api 🛠️
I do have that test in PR #12801 but the response code might change from 403 to 404 now that we also just remove the participant from the room right away. Could you approve/review that PR first? I'll rebase this branch to main and makes changes as needed |
skalidindi53
force-pushed
the
skalidindi53/12804/Remove-user-from-room-after-banned
branch
from
004cde8
to
c61cc10
Compare
lib/Service/BanService.php
Outdated
| @@ -106,6 +107,14 @@ public function createBan(Room $room, string $moderatorActorType, string $modera | |||
| $ban->setBannedTime($bannedTime); | |||
| $ban->setInternalNote($internalNote); | |||
|
|
|||
| //Remove the banned user from the room | |||
| try { | |||
| $bannedParticipant = $this->participantService->getParticipantByActor($room, $bannedActorType, $bannedActorId); | |||
There was a problem hiding this comment.
Skip this block when $bannedActorType === 'ip'
skalidindi53
force-pushed
the
skalidindi53/12804/Remove-user-from-room-after-banned
branch
from
c61cc10
to
c0f36e9
Compare
Signed-off-by: skalidindi53 <s.teja2004@gmail.com>
skalidindi53
force-pushed
the
skalidindi53/12804/Remove-user-from-room-after-banned
branch
from
c0f36e9
to
1c6efac
Compare
nickvergessen
approved these changes
Aug 12, 2024
nickvergessen
deleted the
skalidindi53/12804/Remove-user-from-room-after-banned
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🛠️ API Checklist
🚧 Tasks
🏁 Checklist