Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ParticipantSelectable): add component for participant search results and bulk selection #12850

Merged
merged 2 commits into from
Sep 15, 2024
Merged

feat(ParticipantSelectable): add component for participant search results and bulk selection #12850

merged 2 commits into from
Sep 15, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jul 30, 2024 •
edited by nickvergessen
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 💙 Next Beta (30) milestone Jul 30, 2024
@Antreesy Antreesy requested a review from ShGKme July 30, 2024 09:26
@Antreesy Antreesy self-assigned this Jul 30, 2024
@DorraJaouad DorraJaouad self-requested a review August 1, 2024 12:46
@Antreesy
Copy link
Contributor Author

Antreesy commented Aug 5, 2024

#12819 covers both cases now, so will update this PR later

@Antreesy Antreesy marked this pull request as draft August 5, 2024 19:05
@ShGKme
Copy link
Contributor

ShGKme commented Aug 15, 2024

Actual?

@Antreesy
Copy link
Contributor Author

Antreesy commented Aug 15, 2024 •
edited
Loading

Actual?

No, need to rewrite now (to be a checkbox, not an anchor)

@Antreesy Antreesy mentioned this pull request Aug 23, 2024
Merged
9 tasks
@Antreesy Antreesy force-pushed the fix/noid/participant-search-result branch from bf4d4f4 to fd60d16 Compare August 23, 2024 09:41
@Antreesy Antreesy changed the base branch from main to fix/12800/user-status-typescript August 23, 2024 09:42
@Antreesy Antreesy force-pushed the fix/12800/user-status-typescript branch 5 times, most recently from 034057f to c7b33ee Compare August 25, 2024 08:42
@Antreesy Antreesy force-pushed the fix/12800/user-status-typescript branch 2 times, most recently from d1a1075 to b11f5e9 Compare September 11, 2024 20:51
Base automatically changed from fix/12800/user-status-typescript to main September 13, 2024 12:40
@Antreesy Antreesy force-pushed the fix/noid/participant-search-result branch 2 times, most recently from d1e8e78 to 4212987 Compare September 14, 2024 11:58
@Antreesy Antreesy marked this pull request as ready for review September 14, 2024 11:58
DorraJaouad
DorraJaouad approved these changes Sep 14, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, it works 🦅

@Antreesy
fix(SelectableParticipant): adapt component to use in search results
8cca004 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(Participant): clean up component from search API-related code
d7fb119 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/participant-search-result branch from 5b41e79 to d7fb119 Compare September 15, 2024 08:08
@Antreesy Antreesy merged commit 8dcfb13 into main Sep 15, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/noid/participant-search-result branch September 15, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review design feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
4 participants
@Antreesy @ShGKme @DorraJaouad @nickvergessen