fix(avatar): increase avatar size to 40px #13010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
force-pushed
the
fix/12956/increase-avatar-size
branch
from
7e0a843
to
8bdbedb
Compare
Antreesy
changed the title
ShGKme
reviewed
Aug 16, 2024
src/components/LeftSidebar/ConversationsList/ConversationsListVirtual.vue
Outdated
Show resolved
Hide resolved
src/constants.js
Outdated
| @@ -273,7 +273,7 @@ export const AVATAR = { | |||
| SIZE: { | |||
| EXTRA_SMALL: 22, | |||
| SMALL: 32, | |||
| DEFAULT: 36, | |||
| DEFAULT: 39, | |||
There was a problem hiding this comment.
Is it actually the "default" size? It seems that it is the size of avatar in list items, defined by the list item height (= conversations list and participants list).
There was a problem hiding this comment.
which is also most widely used in project
There was a problem hiding this comment.
But this size is 39 not because we want the default size to be 39 wherever it's used, but because we want it exactly in the list items
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
fix/12956/increase-avatar-size
branch
from
8bdbedb
to
ee85e5f
Compare
Antreesy
changed the title
|
/backport! to stable30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist