-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(avatar): increase avatar size to 40px #13010
Conversation
7e0a843
to
8bdbedb
Compare
src/components/LeftSidebar/ConversationsList/ConversationsListVirtual.vue
Outdated
Show resolved
Hide resolved
src/constants.js
Outdated
@@ -273,7 +273,7 @@ export const AVATAR = { | |||
SIZE: { | |||
EXTRA_SMALL: 22, | |||
SMALL: 32, | |||
DEFAULT: 36, | |||
DEFAULT: 39, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it actually the "default" size? It seems that it is the size of avatar in list items, defined by the list item height (= conversations list and participants list).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which is also most widely used in project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this size is 39 not because we want the default size to be 39 wherever it's used, but because we want it exactly in the list items
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
8bdbedb
to
ee85e5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (avatar size)
/backport! to stable30 |
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist