Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set devMode in CallView component #13026

Merged
merged 4 commits into from
Aug 19, 2024
Merged

fix: set devMode in CallView component #13026

merged 4 commits into from
Aug 19, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

image
image
image

🏁 Checklist


Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good, thanks! Just two small notes:

src/components/CallView/CallView.vue Outdated Show resolved Hide resolved
src/components/CallView/Grid/Grid.vue Outdated Show resolved Hide resolved
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
src/components/CallView/Grid/Grid.vue Outdated Show resolved Hide resolved
src/components/CallView/Grid/Grid.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (+ lint fix)

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy merged commit b2acc99 into main Aug 19, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/noid/call-dev-mode branch August 19, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants