Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct userGroups intersection check for federation access #13030

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

sanskar-soni-9
Copy link
Contributor

@sanskar-soni-9 sanskar-soni-9 commented Aug 19, 2024

Fixed isFederatedEnabledForUser, which was returning true when the intersection of allowedGroups and userGroups was empty. Now it correctly returns true when the intersection is not empty.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

Signed-off-by: Sanskar Soni <sanskarsoni300@gmail.com>
@sanskar-soni-9
Copy link
Contributor Author

also it returns true when there are no allowedGroups is that intended?

@nickvergessen
Copy link
Member

also it returns true when there are no allowedGroups is that intended?

Yeah, that is basically the default

@nickvergessen
Copy link
Member

/backport to stable30

@nickvergessen
Copy link
Member

/backport to stable29

@nickvergessen nickvergessen added this to the 🖤 Next Major (31) milestone Aug 21, 2024
@nickvergessen nickvergessen added 3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐 labels Aug 21, 2024
@nickvergessen nickvergessen merged commit 287c27e into main Aug 21, 2024
68 checks passed
@nickvergessen nickvergessen deleted the fix/adding-federated-user-with-allowed-group branch August 21, 2024 12:29
Copy link

backportbot bot commented Aug 21, 2024

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/13030/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 6d4c528c

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/13030/stable29

Error: Failed to push branch backport/13030/stable29: fatal: could not read Username for 'https://github.com': No such device or address


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@nickvergessen
Copy link
Member

Backport to 29 in #13067 (comment)

Copy link
Contributor

github-actions bot commented Sep 3, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants