-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct userGroups intersection check for federation access #13030
fix: correct userGroups intersection check for federation access #13030
Conversation
Signed-off-by: Sanskar Soni <sanskarsoni300@gmail.com>
also it returns |
Yeah, that is basically the default |
/backport to stable30 |
/backport to stable29 |
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/13030/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 6d4c528c
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/13030/stable29 Error: Failed to push branch backport/13030/stable29: fatal: could not read Username for 'https://github.com': No such device or address Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Backport to 29 in #13067 (comment) |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Fixed
isFederatedEnabledForUser
, which was returning true when the intersection ofallowedGroups
anduserGroups
was empty. Now it correctly returns true when the intersection is not empty.🏁 Checklist
docs/
has been updated or is not required