Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(style): apply NcDialog header styles to NcModal headers #13031

Merged
merged 1 commit into from
Aug 19, 2024
Merged

fix(style): apply NcDialog header styles to NcModal headers #13031

merged 1 commit into from
Aug 19, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Aug 19, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image
image image
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Aug 19, 2024
@Antreesy Antreesy self-assigned this Aug 19, 2024
@Antreesy
fix(style): apply NcDialog header styles to NcModal headers
e4113b1 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/12997/modal-headers-styling branch from c021db4 to e4113b1 Compare August 19, 2024 13:36
@Antreesy
Copy link
Contributor Author

/backport to stable30

@Antreesy Antreesy merged commit 83ec165 into main Aug 19, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/12997/modal-headers-styling branch August 19, 2024 15:30
@backportbot backportbot bot mentioned this pull request Aug 19, 2024
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels
3. to review design feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @ShGKme