Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fileUpload): don't duplicate file templates in store #13121

Merged
merged 2 commits into from
Sep 2, 2024
Merged

fix(fileUpload): don't duplicate file templates in store #13121

merged 2 commits into from
Sep 2, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Aug 23, 2024 •
edited
Loading

☑️ Resolves

  • Fix duplicating of templates

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image Screenshot from 2024-08-23 18-29-30

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added 3. to review bug feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings labels Aug 23, 2024
@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Aug 23, 2024
@Antreesy Antreesy self-assigned this Aug 23, 2024
@Antreesy
fix(upload): don't create template duplicates in store
8009229 
Signed-off-by: Antreesy <antreesy.web@gmail.com>
@Antreesy
fix(upload): don't initiate new server request for templates
1b5baf7 
Signed-off-by: Antreesy <antreesy.web@gmail.com>
@Antreesy
Copy link
Contributor Author

Antreesy commented Sep 2, 2024

/backport to stable30

@Antreesy Antreesy requested a review from ShGKme September 2, 2024 10:30
DorraJaouad
DorraJaouad approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense 👍🏻
I couldn't reproduce it though

@Antreesy Antreesy merged commit 9288857 into main Sep 2, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/noid/dedupe-attachments branch September 2, 2024 12:31
@backportbot backportbot bot mentioned this pull request Sep 2, 2024
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @ShGKme @DorraJaouad