Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor connection failed description #13185

Merged
merged 2 commits into from
Sep 3, 2024
Merged

fix: refactor connection failed description #13185

merged 2 commits into from
Sep 3, 2024

Conversation

DorraJaouad
Copy link
Contributor

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Screenshot 2024-08-30 111330 Screenshot 2024-08-30 111116
Before Screenshot 2024-08-30 112219

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad added this to the 🖤 Next Major (31) milestone Aug 30, 2024
@DorraJaouad DorraJaouad self-assigned this Aug 30, 2024
ShGKme
ShGKme reviewed Aug 30, 2024
View reviewed changes
src/utils/signaling.js Outdated Show resolved Hide resolved
src/components/CallView/shared/EmptyCallView.vue Outdated Show resolved Hide resolved
src/components/CallView/shared/EmptyCallView.vue Outdated Show resolved Hide resolved
@DorraJaouad DorraJaouad force-pushed the fix/13160/empty-call-view-enhancement branch from 49a11ca to 333e8a9 Compare August 30, 2024 11:55
Antreesy
Antreesy reviewed Aug 30, 2024
View reviewed changes
src/components/CallView/shared/EmptyCallView.vue Outdated Show resolved Hide resolved
src/components/CallView/shared/EmptyCallView.vue Outdated Show resolved Hide resolved
src/components/CallView/shared/EmptyCallView.vue Outdated Show resolved Hide resolved
src/components/CallView/shared/EmptyCallView.vue Outdated Show resolved Hide resolved
Antreesy
Antreesy approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

src/components/CallView/shared/EmptyCallView.vue Outdated Show resolved Hide resolved
@DorraJaouad
fix: refactor connection failed description
157e175 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
fix(EmptyCallView): migrate from icon classes
4cdab82 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the fix/13160/empty-call-view-enhancement branch from 6a5ebf9 to 4cdab82 Compare September 3, 2024 10:21
@Antreesy
Copy link
Contributor

Antreesy commented Sep 3, 2024

/backport to stable30

@Antreesy Antreesy merged commit 0c85aca into main Sep 3, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/13160/empty-call-view-enhancement branch September 3, 2024 10:41
@backportbot backportbot bot mentioned this pull request Sep 3, 2024
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SystemKeeper SystemKeeper SystemKeeper left review comments

@ShGKme ShGKme ShGKme left review comments

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
enhancement feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
4 participants
@DorraJaouad @Antreesy @SystemKeeper @ShGKme