fix(Notification): Fix rich object parameters with non-string values #13200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
requested review from
nickvergessen,
SystemKeeper and
Antreesy
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
fix/notification/rich-object-parameters
branch
from
9e5cda2
to
14a7fdf
Compare
nickvergessen
added
feature: api 🛠️
nickvergessen
approved these changes
Sep 10, 2024
|
/backport to stable30 |
|
/backport to stable29 |
3 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found using nextcloud/server#47662.
I temporarily pointed OCP to my local lib/public so psalm started finding the issues. In the future once the PR is merged it will be enforced by default.
🛠️ API Checklist
🏁 Checklist
docs/has been updated or is not required