Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable30] fix(MessagesList): Fix chat fit in one screen not fetching #13213

Closed
wants to merge 11 commits into from

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Sep 5, 2024

Backport of PR #13174

… to bottom button shown at bottom

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
- Rename showLoadingAnimation to !this.isMessagesListPopulated
- Rename isMessageListPopulated getter to isMessagesListPopulated
- Changed stopFetchingOldMessages logic to a computed prop isChatBeginningReached
- Added chatLoadedIdentifier watcher that marks the moment of chat messages loaded
- Moved checkSticky and wheel event listener to that watcher
- Added skipHeightCheck argument to debounceHandleScroll

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
nextcloud-bot and others added 8 commits September 6, 2024 00:28
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Antreesy <antreesy.web@gmail.com>
Signed-off-by: Antreesy <antreesy.web@gmail.com>
Signed-off-by: Antreesy <antreesy.web@gmail.com>
Signed-off-by: Antreesy <antreesy.web@gmail.com>
… note to self

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
[stable30] fix(TopBar): re-enable upcoming event to all conversations apart from…
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@Antreesy Antreesy closed this Sep 6, 2024
@Antreesy
Copy link
Contributor

Antreesy commented Sep 6, 2024

🤷🏽
Web-interface showed conflicts, although there were none, so I rebased and pushed (to merged already branch by that time)

@Antreesy Antreesy deleted the backport/13174/stable30 branch September 6, 2024 13:35
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants