Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor UX enhancements #13215

Merged
merged 4 commits into from
Sep 6, 2024
Merged

fix: minor UX enhancements #13215

merged 4 commits into from
Sep 6, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Sep 5, 2024

☑️ Resolves

  • LeftSidebar: get rid of forced scrollbars
  • NewMessageUploadEditor: adjust design, add hover effect

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
Screenshot before image
image image
image image

🏁 Checklist

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Sep 5, 2024
@Antreesy Antreesy self-assigned this Sep 5, 2024
@Antreesy Antreesy changed the title fix(LeftSidebar): get rid of forced scrollbars fix: minor UX enhancements Sep 5, 2024
@Antreesy Antreesy added the bug label Sep 5, 2024
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looks good

src/components/LeftSidebar/LeftSidebar.vue Show resolved Hide resolved
Signed-off-by: Antreesy <antreesy.web@gmail.com>
Signed-off-by: Antreesy <antreesy.web@gmail.com>
Signed-off-by: Antreesy <antreesy.web@gmail.com>
Signed-off-by: Antreesy <antreesy.web@gmail.com>
@Antreesy
Copy link
Contributor Author

Antreesy commented Sep 6, 2024

/backport to stable30

@Antreesy Antreesy merged commit 1752706 into main Sep 6, 2024
45 of 46 checks passed
@Antreesy Antreesy deleted the fix/noid/ux-changes branch September 6, 2024 09:20
@ShGKme
Copy link
Contributor

ShGKme commented Sep 6, 2024

  • LeftSidebar: get rid of forced scrollbars

It was there intentionally (in the list). Getting rid of it returns layout shift when scrollbar appears/disappears and makes conversation item not inline other items in the navigation.

image

@DorraJaouad
Copy link
Contributor

It was there intentionally (in the list). Getting rid of it returns layout shift when scrollbar appears/disappears and makes conversation item not inline other items in the navigation.

Maybe it's acceptable like that because invitation counter and navigation items do not belong to the scrollable list and they stay sticky ?

@Antreesy
Copy link
Contributor Author

Antreesy commented Sep 6, 2024

I have a wip commit to calculate user agent width of scrollbar and increase space on the right by that value to align - but does it worth it?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants